Cleanups #195
Cleanups #195
Conversation
| @@ -356,14 +356,10 @@ DISPATCH_EXPORT DISPATCH_NOTHROW void dispatch_atfork_child(void); | |||
| do { (elm)->field.tqe_prev = NULL; } while (0) | |||
|
|
|||
| #if DISPATCH_DEBUG | |||
| // sys/queue.h debugging | |||
| #if defined(__linux__) | |||
| #define QUEUE_MACRO_DEBUG 1 | |||
There was a problem hiding this comment.
this breaks people using libbsd-dev and doesn't hurt, please do not remove.
what you probably want to do is to both set QUEUE_MACRO_DEBUG and TRASHIT to support both (?)
| @@ -24,9 +24,9 @@ | |||
|
|
|||
| #if !HAVE_GETPROGNAME | |||
|
|
|||
| #ifdef __ANDROID__ | |||
| #if defined(__ANDROID__) | |||
There was a problem hiding this comment.
please keep the #ifdef only the removal of the ) below is needed
| @@ -16,6 +16,16 @@ | |||
| #ifndef __DISPATCH__STUBS__INTERNAL | |||
| #define __DISPATCH__STUBS__INTERNAL | |||
|
|
|||
| #if !defined(TAILQ_FOREACH_SAFE) | |||
There was a problem hiding this comment.
please keep consistent style and use #ifndef
There was a problem hiding this comment.
you haven't handled this review feedback.
Please use #ifndef and squash in a single commit before merge, thanks
| (var) && ((temp) = TAILQ_NEXT((var), field), 1); (var) = (temp)) | ||
| #endif | ||
|
|
||
| #if !defined(TRASHIT) |
There was a problem hiding this comment.
please don't do that, TRASHIT is only meant to be set in debug mode
There was a problem hiding this comment.
Just following the android pattern, where the android_stubs.h always define it.
| @@ -16,6 +16,16 @@ | |||
| #ifndef __DISPATCH__STUBS__INTERNAL | |||
| #define __DISPATCH__STUBS__INTERNAL | |||
|
|
|||
| #if !defined(TAILQ_FOREACH_SAFE) | |||
| #define TAILQ_FOREACH_SAFE(var, head, field, temp) \ | |||
| for ((var) = TAILQ_FIRST((head)); \ | |||
There was a problem hiding this comment.
please use tabs for alignment
I got the message through mail but couldn't find where it was made after your force push. |
|
@MadCoder sure, I can squash it into the same change. |
|
Gentle post-holiday ping for @MadCoder |
Clean up trailing characters in android shims. Only define the function when used. TAILQ_FOREACH_SAFE is unavailable in glibc as it is a BSD specific macro. Provide a definition for it in the Linux shims. Only define TRASHIT only on debug builds in android as well.
|
Address the last bit of the review comments that I had missed. |
|
@swift-ci please test |
|
Hmm, seems that I dont have swift-ci rights to this project. Mind running this through @MadCoder? BTW, whats the darwin-pending tag? |
|
@swift-ci please test |
|
It seems that the failure is unrelated? |
Cleanups Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
No description provided.